Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #1180 Update index.md $plugin->incompatible #1181

Merged
merged 1 commit into from
Nov 12, 2024
Merged

fix #1180 Update index.md $plugin->incompatible #1181

merged 1 commit into from
Nov 12, 2024

Conversation

gbarat87
Copy link
Contributor

$plugin->incompatible = [401];
Wrongly defined in the example
It require an Integer and not an array

@netlify Netlify
Copy link

netlify bot commented Nov 11, 2024 •
edited
Loading

✅ Deploy Preview for moodledevdocs ready!

Name Link
🔨 Latest commit 8dd971a
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/6732ce140349b10008d56eff
😎 Deploy Preview https://deploy-preview-1181--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 11, 2024 •
edited
Loading

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 65 🟢 95 🟢 100 🟢 90 🟢 100 Report
/docs/5.0/apis/commonfiles 🟠 51 🟢 93 🟢 100 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 64 🟢 95 🟢 100 🟢 90 🟢 100 Report
/general/releases 🟠 64 🟢 95 🟢 100 🟢 100 🟢 100 Report

@gbarat87 @andrewnicols
Update index.md $plugin->incompatible
8dd971a 
$plugin->incompatible = [401];
Wrongly defined in the example
andrewnicols
andrewnicols approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@andrewnicols andrewnicols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing that issue. I have taken the liberty of porting this to other versions of this file.

@andrewnicols andrewnicols linked an issue Nov 12, 2024 that may be closed by this pull request
[docs] Error in version.php #1180
Closed
@andrewnicols andrewnicols added this pull request to the merge queue Nov 12, 2024
Merged via the queue into moodle:main with commit bd5fa9b Nov 12, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewnicols andrewnicols andrewnicols approved these changes

Assignees

@gbarat87 gbarat87

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docs] Error in version.php
2 participants
@gbarat87 @andrewnicols