68 Fix Fatal error declaration of assert_same_xml #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MDL-81581 moved assert_same_xml() into \question_testcase so any implementation a subclass must match this definition.
Open
daniil-berg
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MDL-81581 moved assert_same_xml() into \question_testcase so any implementation a subclass must match this definition.
While removing type declarations for assert_same_xml()'s parameters would fix this, this PR additionally uses the parent's implementation if present, falling back to the existing implementation if if it isn't to avoid making the plugin dependent on Moodle versions >= 4.4.1. This is a little clunky but makes explicit that the core code change means the existing implementation is considered deprecated.
(In core, MDL-81581 removed qtype plugins' implementations of assert_same_xml(), but we can't do that without making qtype_pmatch dependent on Moodle >= 4.4.1).