Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle NyxExtension options typo #240

Closed
alinturbut opened this issue Jul 28, 2023 · 1 comment · Fixed by #242
Closed

Gradle NyxExtension options typo #240

alinturbut opened this issue Jul 28, 2023 · 1 comment · Fixed by #242

Comments

@alinturbut
Copy link

alinturbut commented Jul 28, 2023

While trying to integrate the Gradle Extension, I've realized that the interface has a typo which can be tricky to spot while setting the options:

geOptions() -> getOptions()

        /**
         * Returns the map of service options.
         * 
         * @return the map of service options.
         */
        public MapProperty<String,String> geOptions() {
            return options;
        }

location:

public MapProperty<String,String> geOptions() {

Created a Pull-Request to address it here: #241

@flelli
Copy link
Collaborator

flelli commented Jul 28, 2023

Thanks a lot @alinturbut ,

I created another PR so I also updated the docs but the fix will be available as 2.4.7 as soon as the pipeline completes (just kicked as I'm writing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants