Use storage overrides in debug and tracing modules #1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgmichel
added
A3-inprogress
tgmichel
added
A0-pleasereview
tgmichel
added
the
B5-clientnoteworthy
librelois
approved these changes
Feb 9, 2022
nanocryk
approved these changes
Feb 9, 2022
librelois
added a commit
that referenced
this pull request
Feb 9, 2022
* Use storage overrides in debug and tracing modules (#1270) * Fixes package-lock dependencies (#1267) * Use storage overrides in debug and tracing modules * Get trace api version using parent BlockId * Proper `eth_traceBlockByNumber/Hash` empty traces Co-authored-by: Alan Sapede <[email protected]> * Update frontier `32b7cf4` (#1265) * Update frontier `32b7cf4` * Fixes package-lock dependencies (#1267) Co-authored-by: Alan Sapede <[email protected]> * v0.19.2 * update Cargo.lock Co-authored-by: tgmichel <[email protected]> Co-authored-by: Alan Sapede <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Use frontier storage overrides instead runtime api for getting block data in the
debugandtracemodules.When using the overrides we rely on the known key
:ethereum_schemavalue, which is always updated on runtime upgrade and thus we are aligned with sensiblepallet_ethereumstorage changes. The goal is to guarantee proper decoding without relying on RuntimeApi version metadata.What important points reviewers should know?
Note that we don't use override fallback - which is the runtime api access - and instead we just
Err. This fallback is only meant for projects that don't want to use storage overrides, which is not the case for us.Is there something left for follow-up PRs?
What alternative implementations were considered?
#1269
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?