Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add identity precompile #2406

Merged
merged 34 commits into from
Aug 30, 2023
Merged

Add identity precompile #2406

merged 34 commits into from
Aug 30, 2023

Conversation

nbaztec
Copy link
Contributor

@nbaztec nbaztec commented Jul 21, 2023 •
edited
Loading

What does it do?

adds identity precompile to interface with substrate's pallet-identity for signed origin extrinsics.
See Identity.sol for the interface

@nbaztec nbaztec marked this pull request as ready for review August 4, 2023 17:33
@nbaztec nbaztec added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited not-breaking Does not need to be mentioned in breaking changes and removed D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Aug 4, 2023
@notlesh
Copy link
Contributor

notlesh commented Aug 7, 2023

I just remembered that there's already a (rather silly) precompile called Identity in frontier: https://github.com/paritytech/frontier/blob/22aaafe089218f6cee625898fff7b953cc793228/frame/evm/precompile/simple/src/lib.rs#L31

Should we give this a more specific name to avoid confusion...?

nanocryk
nanocryk reviewed Aug 28, 2023
View reviewed changes
precompiles/identity/src/lib.rs Outdated Show resolved Hide resolved
precompiles/identity/src/lib.rs Outdated Show resolved Hide resolved
notlesh
notlesh reviewed Aug 28, 2023
View reviewed changes
Copy link
Contributor

@notlesh notlesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I left some nits and also a maybe-important question about using handle.context().caller.

@nbaztec nbaztec requested a review from notlesh August 29, 2023 10:49
notlesh
notlesh approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@notlesh notlesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left a few more nits that aren't critical

@nbaztec nbaztec merged commit a14e31c into master Aug 30, 2023
26 checks passed
@nbaztec nbaztec deleted the nish-identity-precompile branch August 30, 2023 09:31
@noandrea noandrea changed the title [MOON-2459] identity precompile Add identity precompile Aug 31, 2023
@notlesh notlesh added D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@librelois librelois librelois approved these changes

@nanocryk nanocryk nanocryk left review comments

@notlesh notlesh notlesh approved these changes

Assignees
No one assigned
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nbaztec @notlesh @nanocryk @librelois