fix tracing bug: ERC20-XCM transactions were not traced #2429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
librelois
added
B0-silent
|
Coverage generated "Thu Aug 17 14:16:14 UTC 2023": Master coverage: 87.39% |
librelois
changed the title
crystalin
approved these changes
Aug 21, 2023
girazoki
approved these changes
Aug 21, 2023
grw-ms
pushed a commit
that referenced
this pull request
Aug 28, 2023
* add tracing test: trace ERC0-XCM transaction * fix erc20-xcm origin * fix test trace erc20 xcm: tracing usedGas does not apply gas refund
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Fix #2392.
The CallDispatcher implementation trace only calls with Signed Origin, and convert origin on the fly if needed, so we should use the Signed origin instead of the EthereumXcm one.
This PR also add a test to ensure that the fix work.
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?