Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MoonScope Integration #2494

Merged
merged 16 commits into from
Oct 11, 2023
Merged

MoonScope Integration #2494

merged 16 commits into from
Oct 11, 2023

Conversation

timbrinded
Copy link
Contributor

What does it do?

Minor updates to integrate the MoonScope reporting interface to the test data we generate.

What value does it bring to the blockchain users?

Increased chain monitoring and efficiency.

@timbrinded timbrinded added B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited) labels Sep 19, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2023

Coverage generated "Tue Oct 10 16:09:30 UTC 2023":
https://d3ifz9vhxc2wtb.cloudfront.net/pulls/2494/html/index.html

Master coverage: 87.39%
Pull coverage:

@crystalin
Copy link
Collaborator

I'm going to add the CI now that we have the moonscope website setup

@crystalin
Copy link
Collaborator

I've added the MOONSCOPE_TOKEN into the repo secrets

@crystalin crystalin marked this pull request as ready for review September 20, 2023 14:43
@crystalin
Copy link
Collaborator

It gets published there: https://moonscope.kaki.dev/dev
But some error messages are missing @timbrinded

@@ -280,7 +284,8 @@
"runScripts": ["compile-contracts.ts compile"],
"multiThreads": true,
"envVars": ["DEBUG_COLORS=1"],
"reporters": ["html", "basic"],
"reporters": ["basic", "html", "json"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timbrinded I added this one but it makes the output unreadable when you execute manually (because the json is printed :( after the basic report and it is too big)

@@ -625,6 +625,9 @@ jobs:
with:
name: moonbeam
path: target/release
- name: Enforce multi thread limit
run: |
sed -i 's/"multiThreads": true/"multiThreads": 3/g' test/moonwall.config.json
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After Polkadot 1.1.0 merge, we need to remove this

@timbrinded
Copy link
Contributor Author

Fixed the merge conflicts and seems to be ticking over nicely on the published page.

@timbrinded timbrinded merged commit 59b51bc into master Oct 11, 2023
26 checks passed
@timbrinded timbrinded deleted the timbo-moonscope branch October 11, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants