-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pre async-backing] [Moonbase] Use relay-slot number as clocktime #2577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Agusrodri
added
B7-runtimenoteworthy
Changes should be noted in any runtime-upgrade release notes
D5-nicetohaveaudit⚠️
PR contains trivial changes to logic that should be properly reviewed.
breaking
Needs to be mentioned in breaking changes
labels
Nov 24, 2023
librelois
reviewed
Nov 25, 2023
Coverage Report@@ Coverage Diff @@
## master agustin-relay-clocktime +/- ##
===========================================================
- Coverage 80.94% 80.90% -0.04%
Files 287 287
+ Lines 94330 94465 +135
===========================================================
+ Hits 76355 76423 +68
+ Misses 17975 18042 +67
|
Agusrodri
commented
Dec 1, 2023
Agusrodri
commented
Dec 7, 2023
noandrea
added
D9-needsaudit👮
PR contains changes to fund-managing logic that should be properly reviewed and externally audited
and removed
D5-nicetohaveaudit⚠️
PR contains trivial changes to logic that should be properly reviewed.
labels
Jan 12, 2024
librelois
reviewed
Jan 18, 2024
librelois
reviewed
Jan 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks pretty good overall, but we need to understand why a collator now needs a delegation to produce blocks, it's not normal.
librelois
approved these changes
Jan 21, 2024
Agusrodri
force-pushed
the
agustin-relay-clocktime
branch
from
January 22, 2024 15:09
a82a019
to
efba8c0
Compare
elfedy
approved these changes
Jan 24, 2024
Agusrodri
changed the title
[Pre async-backing] Use relay-slot number as clocktime
[Pre async-backing] [Moonbase] Use relay-slot number as clocktime
Jan 25, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
B7-runtimenoteworthy
Changes should be noted in any runtime-upgrade release notes
breaking
Needs to be mentioned in breaking changes
D9-needsaudit👮
PR contains changes to fund-managing logic that should be properly reviewed and externally audited
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Replaces the previous parachain block number that was used as a clocktime in parachain staking by the relay chain slot number.
The reason for this is that it is advised to rely on the relay chain slot number instead of the parachain's block number due to the relay slot is more stable and works better together with the future async-backing changes.
Related forum post: https://forum.polkadot.network/t/blocknumber-vs-timestamps-should-we-abandon-blocktimes-altogether/4077/2
TODO