Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add evm::tracing::Event::Log event #2918

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Add evm::tracing::Event::Log event #2918

merged 1 commit into from
Aug 28, 2024

Conversation

RomarQ
Copy link
Contributor

@RomarQ RomarQ commented Aug 28, 2024

What does it do?

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@RomarQ RomarQ requested a review from pLabarta August 28, 2024 18:43
@RomarQ RomarQ added D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes B0-silent Changes should not be mentioned in any release notes B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes and removed B0-silent Changes should not be mentioned in any release notes labels Aug 28, 2024
Copy link
Contributor

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2168 KB (no changes) ✅

Moonbeam runtime: 2116 KB (no changes) ✅

Moonriver runtime: 2116 KB (no changes) ✅

Compared to latest release (runtime-3100)

Moonbase runtime: 2168 KB (+152 KB compared to latest release) ⚠️

Moonbeam runtime: 2116 KB (+140 KB compared to latest release) ⚠️

Moonriver runtime: 2116 KB (+148 KB compared to latest release) ⚠️

Copy link
Contributor

Coverage Report

@@                  Coverage Diff                  @@
##           master   rq/evm-tracing-log     +/-   ##
=====================================================
  Coverage   80.93%               80.93%   0.00%     
  Files         284                  284             
+ Lines       81715                81724      +9     
=====================================================
  Hits        66136                66136             
+ Misses      15579                15588      +9     
Files Changed Coverage

Coverage generated Wed Aug 28 19:53:11 UTC 2024

@RomarQ RomarQ merged commit e7cec54 into master Aug 28, 2024
44 of 48 checks passed
@RomarQ RomarQ deleted the rq/evm-tracing-log branch August 28, 2024 19:56
gonzamontiel pushed a commit that referenced this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants