Add RPC method moon_getEthSyncBlockRange #2922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
librelois
added
B5-clientnoteworthy
TarekkMA
approved these changes
Aug 30, 2024
WASM runtime size check:Compared to target branchMoonbase runtime: 2188 KB (no changes) ✅ Moonbeam runtime: 2120 KB (no changes) ✅ Moonriver runtime: 2132 KB (no changes) ✅ Compared to latest release (runtime-3102)Moonbase runtime: 2188 KB (+248 KB compared to latest release) Moonbeam runtime: 2120 KB (+220 KB compared to latest release) Moonriver runtime: 2132 KB (+232 KB compared to latest release) |
RomarQ
previously approved these changes
Sep 2, 2024
TarekkMA
previously approved these changes
Sep 2, 2024
|
@librelois the new frontier pin seems to be causing the rust tests to fail. |
noandrea
dismissed stale reviews from gonzamontiel, TarekkMA, and RomarQ
via
93de9e5
gonzamontiel
previously approved these changes
Sep 4, 2024
RomarQ
previously approved these changes
Sep 4, 2024
librelois
changed the title
TarekkMA
previously approved these changes
Sep 5, 2024
RomarQ
dismissed stale reviews from TarekkMA, gonzamontiel, and themself
via
a3aefc5
Coverage Report@@ Coverage Diff @@
## master elois-sync-sql +/- ##
==================================================
+ Coverage 80.92% 80.93% +0.01%
Files 286 286
+ Lines 81932 81965 +33
==================================================
+ Hits 66303 66331 +28
+ Misses 15629 15634 +5
|
TarekkMA
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Add an RPC method that return the range of blocks that are fully indexed in frontier's backend.
Since the frontier backend sync backward, it's useless to return only the latest sync block, we should return the first one (the one closest to genesis) as well.
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?