-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pallet_staking: Introduce Additional Account for Inflation Distribution Alongside PBR #2976
Conversation
WASM runtime size check:Compared to target branchMoonbase runtime: 2288 KB (no changes) ✅ Moonbeam runtime: 2240 KB (no changes) ✅ Moonriver runtime: 2236 KB (no changes) ✅ Compared to latest release (runtime-3200)Moonbase runtime: 2288 KB (+328 KB compared to latest release) Moonbeam runtime: 2240 KB (+316 KB compared to latest release) Moonriver runtime: 2236 KB (+312 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master tarekkma/staking-add-address-2 +/- ##
==================================================================
- Coverage 79.18% 79.12% -0.06%
+ Files 299 300 +1
+ Lines 87673 87957 +284
==================================================================
+ Hits 69419 69594 +175
+ Misses 18254 18363 +109
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments, but overall it's good 👍
New version of #2958, with a simpler design and no storage maps being used
Checklist
Discuss the possibility of moving to pallet_parametersWhat does it do?
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?