convivial-32255: Added footer_information region. #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveenvalecha
force-pushed
the
32255
branch
2 times, most recently
from
1d5c11b
to
588c7ba
Compare
tanashin-kishimoto
requested changes
Jun 12, 2023
| ] | ||
| %} | ||
| {% if page.footer_information %} | ||
| <section{{ footer_information_attributes.addClass(footer_information_classes).setAttribute('role', 'footer information') }}> |
There was a problem hiding this comment.
Please remove the role footer information.
It does not match the aria role.
Refer to https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles
| @@ -0,0 +1,8 @@ | |||
| /*! @convivial_bootstrap/footer_information */ | |||
|
|
|||
| .footer-information { | |||
There was a problem hiding this comment.
You may need the padding even if the information area does not have the color palettes.
This could be changed or not changed depending on your preference.
tanashin-kishimoto
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.