Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Laravel 11 support #2

Merged
merged 5 commits into from
May 23, 2024
Merged

Conversation

RobertBoes
Copy link
Contributor

Adds Laravel 11 support

I did run the tests, however 1 test is failing for me:

   FAIL  Tests\FourXXCardTest
  ⨯ it renders 4xx requests                                                                                                                                                0.01s
  ✓ it includes the card on the dashboard                                                                                                                                  0.04s
  ──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
   FAILED  Tests\FourXXCardTest > it renders 4xx requests                                                                                                    ArgumentCountError
  Too few arguments to function Laravel\Pulse\Storage\DatabaseStorage::store(), 0 passed in /[...]/laravel-pulse-4xx/vendor/laravel/framework/src/Illuminate/Support/Traits/ForwardsCalls.php on line 23 and exactly 1 expected

  at vendor/laravel/pulse/src/Storage/DatabaseStorage.php:42
     38▕      * Store the items.
     39▕      *
     40▕      * @param  \Illuminate\Support\Collection<int, \Laravel\Pulse\Entry|\Laravel\Pulse\Value>  $items
     41▕      */
  ➜  42▕     public function store(Collection $items): void
     43▕     {
     44▕         if ($items->isEmpty()) {
     45▕             return;
     46▕         }

      +6 vendor frames
  7   tests/FourXXCardTest.php:35

This test also fails for me on the main branch, with the same error. So I think I'm missing something regarding setup.

@morrislaptop
Copy link
Owner

Looks like they changed that store method to ingest - thanks for the PR!

@morrislaptop morrislaptop merged commit da1d86f into morrislaptop:main May 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants