Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix EIP20Gateway naming & Use Mosaic for Contracts #55

Merged
merged 2 commits into from
Feb 6, 2019
Merged

Fix EIP20Gateway naming & Use Mosaic for Contracts #55

merged 2 commits into from
Feb 6, 2019

Conversation

hobofan
Copy link
Contributor

@hobofan hobofan commented Feb 5, 2019

  • Make sure EIP20Gateway is used instead of Gateway in docs
  • Removed SimpleToken mentions
  • Adjust Contracts class to use Mosaic abstraction

FIXES #37

@hobofan hobofan self-assigned this Feb 5, 2019
@hobofan hobofan force-pushed the fix_naming branch 2 times, most recently from edd0cb3 to 4ed0807 Compare February 5, 2019 14:58
schemar
schemar approved these changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@schemar schemar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⛵️

I am not sure we still call it value token 🤔

src/Staker/Staker.js Outdated Show resolved Hide resolved
deepesh-kn
deepesh-kn approved these changes Feb 5, 2019
View reviewed changes
Copy link
Collaborator

@deepesh-kn deepesh-kn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@hobofan
Copy link
Contributor Author

hobofan commented Feb 6, 2019

I am not sure we still call it value token 🤔

That will be addressed in #62

@hobofan
Fix up naming
3c744b2 
- Make sure EIP20Gateway is used instead of Gateway in docs
- Removed SimpleToken mentions
- Adjust Contracts class to use Mosaic abstraction

FIXES mosaicdao#37
@hobofan
Fix JSDoc comment
70906c5
@hobofan hobofan changed the title Fix naming & Use Mosaic for Contracts Fix EIP20Gateway naming & Use Mosaic for Contracts Feb 6, 2019
@hobofan hobofan merged commit ea78b9a into mosaicdao:develop Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepesh-kn deepesh-kn deepesh-kn approved these changes

@schemar schemar schemar approved these changes

Assignees

@hobofan hobofan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hobofan @schemar @deepesh-kn