Skip to content

Commit

Permalink
GSD files now include 1,4 special pairs for use in OPLS (#473)
Browse files Browse the repository at this point in the history
  • Loading branch information
whitead authored and justinGilmer committed Dec 22, 2018
1 parent c476cda commit 3ca5f8a
Show file tree
Hide file tree
Showing 2 changed files with 55 additions and 1 deletion.
36 changes: 35 additions & 1 deletion mbuild/formats/gsdwriter.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@


def write_gsd(structure, filename, ref_distance=1.0, ref_mass=1.0,
ref_energy=1.0, rigid_bodies=None, shift_coords=True):
ref_energy=1.0, rigid_bodies=None, shift_coords=True,
write_special_pairs=True):
"""Output a GSD file (HOOMD v2 default data format).
Parameters
Expand All @@ -39,6 +40,9 @@ def write_gsd(structure, filename, ref_distance=1.0, ref_mass=1.0,
part of a rigid body.
shift_coords : bool, optional, default=True
Shift coordinates from (0, L) to (-L/2, L/2) if necessary.
write_special_pairs : bool, optional, default=True
Writes out special pair information necessary to correctly use the OPLS fudged 1,4 interactions
in HOOMD.
Notes
-----
Expand Down Expand Up @@ -79,13 +83,16 @@ def write_gsd(structure, filename, ref_distance=1.0, ref_mass=1.0,

_write_particle_information(gsd_file, structure, xyz, ref_distance,
ref_mass, ref_energy, rigid_bodies)
if write_special_pairs:
_write_pair_information(gsd_file, structure)
if structure.bonds:
_write_bond_information(gsd_file, structure)
if structure.angles:
_write_angle_information(gsd_file, structure)
if structure.rb_torsions:
_write_dihedral_information(gsd_file, structure)


gsd.hoomd.create(filename, gsd_file)

def _write_particle_information(gsd_file, structure, xyz, ref_distance,
Expand Down Expand Up @@ -124,6 +131,33 @@ def _write_particle_information(gsd_file, structure, xyz, ref_distance,
rigid_bodies = [-1 if body is None else body for body in rigid_bodies]
gsd_file.particles.body = rigid_bodies

def _write_pair_information(gsd_file, structure):
"""Write the special pairs in the system.
Parameters
----------
gsd_file :
The file object of the GSD file being written
structure : parmed.Structure
Parmed structure object holding system information
"""
pair_types = []
pair_typeid = []
pairs = []
for ai in structure.atoms:
for aj in ai.dihedral_partners:
#make sure we don't double add
if ai.idx > aj.idx:
ps = '-'.join(sorted([ai.type, aj.type], key=natural_sort))
if ps not in pair_types:
pair_types.append(ps)
pair_typeid.append(pair_types.index(ps))
pairs.append((ai.idx, aj.idx))
gsd_file.pairs.types = pair_types
gsd_file.pairs.typeid = pair_typeid
gsd_file.pairs.group = pairs
gsd_file.pairs.N = len(pairs)

def _write_bond_information(gsd_file, structure):
"""Write the bonds in the system.
Expand Down
20 changes: 20 additions & 0 deletions mbuild/tests/test_gsd.py
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,26 @@ def test_bonded(self, ethane):
assert np.array_equal(dihedral_atoms, expected_dihedral_atoms)
assert np.array_equal(dihedral_typeids, np.zeros(n_dihedrals))

@pytest.mark.skipif(not has_gsd, reason="GSD package not installed")
def test_pairs(self, benzene):
from foyer import Forcefield
import gsd, gsd.pygsd

benzene.save(filename='benzene.gsd', forcefield_name='oplsaa')
gsd_file = gsd.pygsd.GSDFile(open('benzene.gsd', 'rb'))
frame = gsd.hoomd.HOOMDTrajectory(gsd_file).read_frame(0)

structure = benzene.to_parmed()
forcefield = Forcefield(name='oplsaa')
structure = forcefield.apply(structure)

# Pairs
assert len(frame.pairs.types) == 3
assert frame.pairs.N == 21




@pytest.mark.skipif(not has_gsd, reason="GSD package not installed")
def test_units(self, ethane):
import gsd, gsd.pygsd
Expand Down

0 comments on commit 3ca5f8a

Please sign in to comment.