-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify bond graph to include independent particle #1036
Merged
daico007
merged 13 commits into
mosdef-hub:main
from
daico007:populate_bondgraph_with_ind_node
Jun 24, 2022
Merged
Modify bond graph to include independent particle #1036
daico007
merged 13 commits into
mosdef-hub:main
from
daico007:populate_bondgraph_with_ind_node
Jun 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1036 +/- ##
=======================================
Coverage 90.38% 90.39%
=======================================
Files 64 64
Lines 9029 9027 -2
=======================================
- Hits 8161 8160 -1
+ Misses 868 867 -1 ☔ View full report in Codecov by Sentry. |
…late_bondgraph_with_ind_node
This PR seems to be passing all the existing MOSDEF-GOMC-GMSO tests if you add the other PRs data to the compound.py file:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
Currently, compound bond graph only include bonded particles. This PR modify
mb.Compound
so that its bond graph also include independent/non-bonded particle.PR Checklist