-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dihedral rotator function #1039
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
21f0bc8
Add rotate dihedral function
uppittu11 c7cab73
Add networkx soft import to rotate_dihedral function
uppittu11 87993bf
Add ethane unit test for rotate_dihedral
uppittu11 7ffc7ff
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] b6cf289
Add missing parameters header in rotate_dihedral docstring
uppittu11 c68b939
Remove redundant code in if-statement
uppittu11 8432cc6
Merge branch 'dihedral_rotator' of https://github.com/uppittu11/mbuil…
uppittu11 db7743a
Merge branch 'main' into dihedral_rotator
daico007 1f84d91
Merge branch 'main' into dihedral_rotator
chrisjonesBSU 595729e
Merge branch 'main' into dihedral_rotator
daico007 1b37e34
add more test case
daico007 11b4721
Merge branch 'main' into dihedral_rotator
daico007 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add a test with a less symmetric molecule than ethane. This is a better proof of concept that the atoms were translated properly, especially if we're dealing with a long molecule polymers.