-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecation warnig in packing.py
and replace .format()
with f-strings where possible.
#1192
Merged
chrisjonesBSU
merged 16 commits into
mosdef-hub:main
from
chrisjonesBSU:fix-dep-warnings
Aug 19, 2024
Merged
Fix deprecation warnig in packing.py
and replace .format()
with f-strings where possible.
#1192
chrisjonesBSU
merged 16 commits into
mosdef-hub:main
from
chrisjonesBSU:fix-dep-warnings
Aug 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…executable PACKMOL = find_executable(packmol)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1192 +/- ##
=======================================
Coverage 87.34% 87.34%
=======================================
Files 62 62
Lines 6584 6584
=======================================
Hits 5751 5751
Misses 833 833 ☔ View full report in Codecov by Sentry. |
Merging this after discussing with Cal on a mosdef dev call. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
This is a PR that does 2 things:
find_executable
indistutils
.format()
with f-strings in many places in an effort to clean things up a bit (I was bored at an airport)PR Checklist