Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warnig in packing.py and replace .format() with f-strings where possible. #1192

Merged
merged 16 commits into from
Aug 19, 2024

Conversation

chrisjonesBSU
Copy link
Contributor

PR Summary:

This is a PR that does 2 things:

  1. Fix a deprecation warning that is being raised about find_executable in distutils
>>> from distutils.spawn import find_executable
>>> find_executable("PACKMOL")
<stdin>:1: DeprecationWarning: Use shutil.which instead of find_executable
  1. It also replaces .format() with f-strings in many places in an effort to clean things up a bit (I was bored at an airport)

PR Checklist


  • Includes appropriate unit test(s)
  • Appropriate docstring(s) are added/updated
  • Code is (approximately) PEP8 compliant
  • Issue(s) raised/addressed?

mbuild/packing.py Fixed Show resolved Hide resolved
mbuild/packing.py Fixed Show resolved Hide resolved
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.34%. Comparing base (0ca30d2) to head (e120962).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1192   +/-   ##
=======================================
  Coverage   87.34%   87.34%           
=======================================
  Files          62       62           
  Lines        6584     6584           
=======================================
  Hits         5751     5751           
  Misses        833      833           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisjonesBSU
Copy link
Contributor Author

Merging this after discussing with Cal on a mosdef dev call.

@chrisjonesBSU chrisjonesBSU merged commit 41216c1 into mosdef-hub:main Aug 19, 2024
21 checks passed
@chrisjonesBSU chrisjonesBSU deleted the fix-dep-warnings branch August 19, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant