Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MOSIP logo trimed in VC card #206

Closed
Anushree09-N opened this issue Nov 4, 2022 · 2 comments · Fixed by #275
Closed

MOSIP logo trimed in VC card #206

Anushree09-N opened this issue Nov 4, 2022 · 2 comments · Fixed by #275
Assignees
@Anushree09-N
Labels
beta_must_fix bug Something isn't working dependencies Pull requests that update a dependency file Minor triaged Triage completed
Milestone
Sprint-17 08 Dec 22

Comments

@Anushree09-N
Copy link

Describe the bug
MOSIP logo is trimmed in both VC's preview in home page and VC detail view page.

To Reproduce

  1. Open app and head to home page
  2. click on add ID and download VC
  3. view VC

Current behavior
MOSIP logo trimed in VC card.

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
File (8)
File (7)

Smartphone (please complete the following information):

  • Device: iPhone7 & iPhone XR
  • OS: 15.4.1
  • Inji app version: 0.4.0 (16) in test flight
  • MOSIP Version: 1.2.1
  • MOSIP server: qa-121.mosip.net

Additional context
#142
@Anushree09-N Anushree09-N added bug Something isn't working triage This issue is pending confirmation and planning and should not be worked on yet Major labels Nov 4, 2022
@Sujithbn Sujithbn added dependencies Pull requests that update a dependency file beta_must_fix and removed Major labels Nov 7, 2022
@Sujithbn Sujithbn added triaged Triage completed and removed triage This issue is pending confirmation and planning and should not be worked on yet labels Nov 7, 2022
@rakhimosip rakhimosip removed their assignment Nov 8, 2022
pmigueld added a commit that referenced this issue Nov 9, 2022
@pmigueld
Merge pull request #206 from idpass/cherrypick/046f2d2
0745db1 
Fixed app crashing and language issue
@Sujithbn Sujithbn moved this to To do (under triage) in MOSIP Inji issues tracking Nov 17, 2022
@Sujithbn Sujithbn added this to the Sprint-17 08 Dec 22 milestone Nov 24, 2022
@Anil-kumar-Majji
Copy link
Contributor

Anil-kumar-Majji commented Nov 24, 2022 •
edited
Loading

@rakhimosip The above issue was rectified by adjusting logo styles in module defaultTheme.tsx. Respective raised PR(#275 ) was submitted to @Sujithbn. Check the expected logs in the below screenshots.
In Detailed VC-card
In VC-cards

@Sujithbn Sujithbn moved this from To do (under triage) to Code review in MOSIP Inji issues tracking Nov 25, 2022
@Sujithbn Sujithbn linked a pull request Nov 28, 2022 that will close this issue
Fixed Issue-206 #275
Merged
@Sujithbn Sujithbn moved this from Code review to Merged in MOSIP Inji issues tracking Nov 29, 2022
@Sujithbn Sujithbn moved this from Merged to QA (test) in MOSIP Inji issues tracking Dec 12, 2022
@damodarguru
Copy link

damodarguru commented Mar 7, 2023 •
edited
Loading

Verified this issue in the new build, the issue is fixed, we are getting full logo of MOSIP in VC card, I am attaching the screenshot and the device details below for reference. Hence closing this bug.

Screenshot :
image

Build number :
image

Tested in;

Mimoto version: 1.2.0.1
MOSIP Version: qa-1201-b2.mosip.net

@github-project-automation github-project-automation bot moved this from QA (test) to Merged in MOSIP Inji issues tracking Mar 13, 2023
@vijay151096 vijay151096 mentioned this issue Mar 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Anushree09-N Anushree09-N

Labels
beta_must_fix bug Something isn't working dependencies Pull requests that update a dependency file Minor triaged Triage completed
Projects
MOSIP Inji issues tracking
Status: Merged
Milestone
Sprint-17 08 Dec 22
Development

Successfully merging a pull request may close this issue.

Fixed Issue-206 Anil-kumar-Majji/inji_App
7 participants
@Anushree09-N @rakhimosip @srikanth716 @santhoshsunder @Anil-kumar-Majji @Sujithbn @damodarguru