Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: replace PR Title Checker with a stable action #485

Closed
Tracked by #532
Xunzhuo opened this issue Apr 18, 2022 · 1 comment · Fixed by #526
Closed
Tracked by #532

ci: replace PR Title Checker with a stable action #485

Xunzhuo opened this issue Apr 18, 2022 · 1 comment · Fixed by #526

Comments

@Xunzhuo
Copy link
Member

Xunzhuo commented Apr 18, 2022

replace pr title validator

compared with thehanimo/pr-title-checker:

amannn/action-semantic-pull-request is an ideal workflow to check PR Validation, it is followed by semantic style, as for thehanimo/pr-title-checker, we need to write the pattern in json config, and actually thery are not followed by semantic style tyle, and we have to maintain another json config, which is no-needed.

Also this project is more active than hehanimo/pr-title-checker, which means this project is more stable to be maintained. We should choose a stable and active action as our github workflow, otherwise if any bugs happened, we will get into troubles and hard for us to fix, which leads us to change our actions repeatedly, this is not what maintainers want to see.

@Xunzhuo Xunzhuo closed this as completed Apr 18, 2022
@Xunzhuo Xunzhuo reopened this May 3, 2022
@Xunzhuo Xunzhuo changed the title ci: remove PR Title Checker and update it with semantic-pull-request ci: replace PR Title Checker with a stable action May 3, 2022
@github-actions
Copy link

github-actions bot commented Jun 3, 2022

This issue has been automatically marked as stale because it has not had recent activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue or help wanted) or other activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants