Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reopen unit test in CI #529

Closed
4 tasks
Tracked by #532
seeflood opened this issue May 3, 2022 · 7 comments · Fixed by #546
Closed
4 tasks
Tracked by #532

Reopen unit test in CI #529

seeflood opened this issue May 3, 2022 · 7 comments · Fixed by #546
Assignees
Labels
area/ci good first issue Good for newcomers help wanted Extra attention is needed

Comments

@seeflood
Copy link
Member

seeflood commented May 3, 2022

Our CI won't run unit tests due to #483 . Now it's time to reopen it.

We shall:

@seeflood
Copy link
Member Author

seeflood commented May 3, 2022

@Xunzhuo Hi, can I assign it to you?

@seeflood seeflood added good first issue Good for newcomers help wanted Extra attention is needed area/ci labels May 3, 2022
@Xunzhuo
Copy link
Member

Xunzhuo commented May 3, 2022

Sure, this is what I want too, since the new pipelines are running, there are a lot of things need to do make it stable.

@Xunzhuo
Copy link
Member

Xunzhuo commented May 3, 2022

I will start a new issue to cover all the tasks related to the new Pipelines, make it stable.

@seeflood
Copy link
Member Author

seeflood commented May 3, 2022

ok!

@Xunzhuo
Copy link
Member

Xunzhuo commented May 5, 2022

Our CI won't run unit tests due to #483 . Now it's time to reopen it.

We shall:

Should not we test cases in pkg ?

@Xunzhuo
Copy link
Member

Xunzhuo commented May 5, 2022

cc @seeflood, please check this if it is missed:)

@seeflood
Copy link
Member Author

seeflood commented May 5, 2022

Should not we test cases in pkg ?

@Xunzhuo We should. I didn't put it here because your scripts already test this package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants