Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Publish subscription caused by metadata does not fill in caused … #524

Merged
merged 5 commits into from
May 3, 2022

Conversation

akkw
Copy link
Contributor

@akkw akkw commented May 2, 2022

…by painc

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


seeflood
seeflood previously approved these changes May 2, 2022
Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seeflood seeflood requested a review from wenxuwan May 2, 2022 07:14
@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #524 (d0c4327) into main (842bedb) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head d0c4327 differs from pull request most recent head 56ffd5b. Consider uploading reports for the commit 56ffd5b to get more accurate results

@@            Coverage Diff             @@
##             main     #524      +/-   ##
==========================================
+ Coverage   60.60%   60.62%   +0.01%     
==========================================
  Files         120      120              
  Lines        6382     6384       +2     
==========================================
+ Hits         3868     3870       +2     
  Misses       2144     2144              
  Partials      370      370              
Impacted Files Coverage Δ
pkg/runtime/runtime.go 60.60% <100.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81daaa9...56ffd5b. Read the comment docs.

Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seeflood
Copy link
Member

seeflood commented May 3, 2022

Currently we can ignore the codecov error because the new CI doesn't run UT, see #529

Copy link
Member

@JervyShi JervyShi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JervyShi JervyShi merged commit d0f7841 into mosn:main May 3, 2022
@seeflood seeflood linked an issue May 3, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pub/sub configure no metadata will be panic
3 participants