Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: deadlink checker can't find out dead links #596

Closed
seeflood opened this issue May 23, 2022 · 1 comment · Fixed by #609
Closed

ci: deadlink checker can't find out dead links #596

seeflood opened this issue May 23, 2022 · 1 comment · Fixed by #609
Labels
area/ci good first issue Good for newcomers help wanted Extra attention is needed

Comments

@seeflood
Copy link
Member

seeflood commented May 23, 2022 •
edited
Loading

What happened:
To test the deadlink checker, I submitted a PR #595 with a wrong url :
image

But it pass the CI successfully :
https://github.com/mosn/layotto/runs/6551464453?check_suite_focus=true
image

What you expected to happen:
It shouldn't pass the CI

How to reproduce it (as minimally and precisely as possible):
Write image with <img> instead of ![](xxxx):
image

Anything else we need to know?:
@seeflood seeflood changed the title deadlink checker can't find out deadlink deadlink checker can't find out dead links May 23, 2022
@seeflood seeflood added good first issue Good for newcomers help wanted Extra attention is needed area/ci labels May 23, 2022
@seeflood seeflood mentioned this issue May 23, 2022
Closed
25 tasks
@seeflood seeflood changed the title deadlink checker can't find out dead links ci: deadlink checker can't find out dead links May 23, 2022
@seeflood
Copy link
Member Author

similar issue:
tcort/markdown-link-check#165

xujiajiadexiaokeai added a commit to xujiajiadexiaokeai/layotto that referenced this issue May 26, 2022
@xujiajiadexiaokeai
fix: dead-link-checker can't find out dead links (mosn#596)
46f2546 
update markdown-link-check version v3.8.7 -> v3

optimize check-dead-link result display

ignore internal anchor
@xujiajiadexiaokeai xujiajiadexiaokeai mentioned this issue May 26, 2022
Merged
seeflood pushed a commit that referenced this issue May 30, 2022
@xujiajiadexiaokeai
fix: dead-link-checker can't find out dead links (#596) (#609)
d991eba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ci good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: dead-link-checker can't find out dead links (#596) xujiajiadexiaokeai/layotto
1 participant
@seeflood