Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add prometheus demo #480

Merged
merged 34 commits into from
May 14, 2022
Merged

Conversation

LXPWing
Copy link
Member

@LXPWing LXPWing commented Apr 16, 2022

What this PR does:
Add prometheus demo

Fixes #466

@codecov
Copy link

codecov bot commented Apr 16, 2022

Codecov Report

Merging #480 (d5226ec) into main (1947177) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #480   +/-   ##
=======================================
  Coverage   60.70%   60.70%           
=======================================
  Files         120      120           
  Lines        6382     6382           
=======================================
  Hits         3874     3874           
  Misses       2139     2139           
  Partials      369      369           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1947177...d5226ec. Read the comment docs.

@seeflood
Copy link
Member

seeflood commented Apr 18, 2022

There are some misunderstandings here 😢
In fact, I mean adding a quickstart document, including some steps like deploying prometheus and layotto, running a demo, and opening the web page to see the effect.
You can take the skywalking quickstart demo as an example

@seeflood
Copy link
Member

seeflood commented May 5, 2022

@LXPWing Hi, the new CI is merged and now we can continue with this PR :)

@mosn-community-bot mosn-community-bot bot added size/L and removed size/M labels May 7, 2022
docs/zh/start/trace/prometheus.md Outdated Show resolved Hide resolved
docs/en/start/trace/prometheus.md Outdated Show resolved Hide resolved
docs/zh/start/trace/prometheus.md Outdated Show resolved Hide resolved
docs/en/start/trace/prometheus.md Outdated Show resolved Hide resolved
demo/prometheus/prometheus.yml Show resolved Hide resolved
docs/zh/start/trace/prometheus.md Show resolved Hide resolved
docs/en/start/trace/skywalking.md Outdated Show resolved Hide resolved
docs/en/start/trace/skywalking.md Outdated Show resolved Hide resolved
@seeflood
Copy link
Member

@LXPWing hi, I modified your branch. I deleted prometheus.png and upload it to a CDN, so that readers can download this image faster.
Please take care not to git push -f and overwrite it :)
image

@LXPWing
Copy link
Member Author

LXPWing commented May 10, 2022

The existing error has been fixed, thank you for your review.

docs/en/start/trace/skywalking.md Show resolved Hide resolved
docs/en/start/trace/skywalking.md Outdated Show resolved Hide resolved
docs/zh/start/trace/prometheus.md Show resolved Hide resolved
docs/en/start/trace/prometheus.md Outdated Show resolved Hide resolved
docs/en/start/trace/prometheus.md Outdated Show resolved Hide resolved
docs/zh/start/trace/prometheus.md Show resolved Hide resolved
@LXPWing
Copy link
Member Author

LXPWing commented May 11, 2022

I don't know how to solve this problem QaQ
image

@seeflood
Copy link
Member

@LXPWing It seems that github workflow could not connect to codecov successfully. Let's try again

docs/en/start/trace/prometheus.md Show resolved Hide resolved
docs/en/start/trace/prometheus.md Show resolved Hide resolved
docs/zh/start/trace/prometheus.md Show resolved Hide resolved
docs/zh/start/trace/prometheus.md Outdated Show resolved Hide resolved
docs/en/start/trace/skywalking.md Show resolved Hide resolved
Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I deleted docs/img/trace/layotto.png and uploaded it to the CDN.
Thanks for your contribution!

@seeflood seeflood merged commit b248836 into mosn:main May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate with Prometheus
3 participants