Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement oss interface #556

Merged
merged 159 commits into from
Jul 25, 2022
Merged

feat: implement oss interface #556

merged 159 commits into from
Jul 25, 2022

Conversation

wenxuwan
Copy link
Member

@wenxuwan wenxuwan commented May 11, 2022 •
edited
Loading

What this PR does:

Which issue(s) this PR fixes:

Fixes #510

Special notes for your reviewer:

对于支持S3的原因可以参考 #510

Does this PR introduce a user-facing change?:

seeflood
seeflood requested changes May 11, 2022
View reviewed changes
pkg/grpc/grpc_api.go Outdated Show resolved Hide resolved
@seeflood seeflood changed the title layotto support s3 [WIP]feat: layotto support s3 May 13, 2022
seeflood
seeflood requested changes May 13, 2022
View reviewed changes
configs/config_in_memory.json Outdated Show resolved Hide resolved
spec/proto/extension/v1/s3.proto Outdated Show resolved Hide resolved
@seeflood seeflood mentioned this pull request May 13, 2022
Open
seeflood
seeflood requested changes Jul 22, 2022
View reviewed changes
components/oss/registry.go Outdated Show resolved Hide resolved
components/oss/registry.go Outdated Show resolved Hide resolved
components/oss/registry.go Outdated Show resolved Hide resolved
components/oss/registry.go Outdated Show resolved Hide resolved
components/oss/registry.go Outdated Show resolved Hide resolved
components/oss/registry.go Outdated Show resolved Hide resolved
components/oss/registry.go Outdated Show resolved Hide resolved
components/oss/registry.go Outdated Show resolved Hide resolved
components/oss/registry.go Outdated Show resolved Hide resolved
@wenxuwan wenxuwan force-pushed the file_s3 branch 2 times, most recently from a639b51 to 6349308 Compare July 22, 2022 06:49
@seeflood seeflood mentioned this pull request Jul 23, 2022
Closed
seeflood
seeflood requested changes Jul 23, 2022
View reviewed changes
components/oss/registry.go Outdated Show resolved Hide resolved
@seeflood
Copy link
Member

seeflood commented Jul 23, 2022 •
edited
Loading

@wenxuwan Looks good to me overall. Please fix the CI failure.
Thanks!

There are many things we have to do after this PR is merged, and I record them at #723

@seeflood seeflood closed this Jul 25, 2022
@seeflood seeflood reopened this Jul 25, 2022
zhenjunMa
zhenjunMa previously approved these changes Jul 25, 2022
View reviewed changes
seeflood
seeflood approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seeflood seeflood merged commit 0b2d62f into mosn:main Jul 25, 2022
This was referenced Jul 29, 2022
Closed
Merged
Open
@seeflood seeflood mentioned this pull request Aug 15, 2022
Closed
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seeflood seeflood seeflood approved these changes

@zhenjunMa zhenjunMa zhenjunMa approved these changes

Assignees
No one assigned
Labels
area/api area/community cla:yes size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

proposal: make file api Portable
4 participants
@wenxuwan @seeflood @zhenjunMa @Xunzhuo