-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix CI issues and improve make script #562
Conversation
Codecov Report
@@ Coverage Diff @@
## main #562 +/- ##
=======================================
Coverage 60.70% 60.70%
=======================================
Files 120 120
Lines 6382 6382
=======================================
Hits 3874 3874
Misses 2139 2139
Partials 369 369 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, no need to over-think this, as long as it is benefical to confirm any mistakes in codes. I am OK with this.
Signed-off-by: seeflood <[email protected]>
What this PR does:
fix CI issues and improve make script.
More specifically, fix #561 and #558
Which issue(s) this PR fixes:
Fixes #561
Fixes #558
Special notes for your reviewer:
Does this PR introduce a user-facing change?: