Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix CI issues and improve make script #562

Merged
merged 8 commits into from
May 14, 2022

Conversation

seeflood
Copy link
Member

What this PR does:
fix CI issues and improve make script.
More specifically, fix #561 and #558

Which issue(s) this PR fixes:

Fixes #561
Fixes #558

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@seeflood seeflood requested a review from Xunzhuo May 13, 2022 00:51
@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #562 (176e4c5) into main (1947177) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #562   +/-   ##
=======================================
  Coverage   60.70%   60.70%           
=======================================
  Files         120      120           
  Lines        6382     6382           
=======================================
  Hits         3874     3874           
  Misses       2139     2139           
  Partials      369      369           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b248836...176e4c5. Read the comment docs.

Makefile Outdated Show resolved Hide resolved
Xunzhuo
Xunzhuo previously approved these changes May 13, 2022
Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no need to over-think this, as long as it is benefical to confirm any mistakes in codes. I am OK with this.

Signed-off-by: seeflood <[email protected]>
@Xunzhuo Xunzhuo merged commit 15daa68 into mosn:main May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: let make all command test all the quickstart docs quickstart tests error
3 participants