-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement sequencer API with postgresql #567
Conversation
Hi @azhsmesos, welcome to mosn community, Please sign Contributor License Agreement! After you signed CLA, we will automatically sync the status of this pull request in 3 minutes. |
请问merge的审查什么时候呢, 过与不过会告知吗 |
感谢贡献!! 在跑CI啦,可以先修复一下 CI 报错 |
这个cr我可以手动触发吗,每次我commit后就手动触发跑一下,第二就是咱们pr有没有一个规格文档来介绍,比如需要保证什么格式啥的,类名规格这些的 |
github 有个限制,每个仓库的 first-time contributor 提的pr ,不能自动跑CI,每次都得维护者手动点CI。合并一次pr、成为 contributor 后,就能自动触发 CI 啦。 |
有Layotto 贡献者指南 和 Layotto GitHub Workflows说明 ,可以看下,如果有不明白的我再优化文档。 另外,PR title要加个前缀哈, |
hello 帮下我running workflows~ |
又commit了一下,刚刚看报错是由于我提供的sql脚本中并没有声明有效的许可证头,不过sql文件注释是 -- ,而许可证那个是// ,不过我已经在sql文件中加上了,sql文件主要是提供sql表脚本,不在项目中具体执行,虽然在sql文件中使用 // 不符合常理,不过应该没啥影响吧,主要为了跑ci,麻烦在帮忙运行一下,如果在失败我就把sql脚本 删掉,这次不上传sql 脚本了 |
Codecov Report
@@ Coverage Diff @@
## main #567 +/- ##
==========================================
- Coverage 60.70% 59.84% -0.86%
==========================================
Files 120 122 +2
Lines 6382 6473 +91
==========================================
Hits 3874 3874
- Misses 2139 2230 +91
Partials 369 369
Continue to review full report at Codecov.
|
@azhsmesos hi,some problems:
you can take a look at the implementation of other sequencer components. |
@ZLBer the empty file may be the image file generated by me after startup, and there is residue when I delete it |
What this PR does:
新增基于postgresql实现分布式自增唯一id组件
Which issue(s) this PR fixes: 利用号段模式+双buffer,基于postgresql实现分布式自增id组件
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: 主要修改在components/sequencer/postgresql包下