Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: webassembly code analysis #575

Merged
merged 12 commits into from
May 26, 2022
Merged

Conversation

rayowang
Copy link
Member

What this PR does:
webassembly code analysis
Which issue(s) this PR fixes:
#427

@seeflood
Copy link
Member

I wonder which tool you used to draw these diagrams. These diagrams look very professional, much better than mine 😢

@rayowang
Copy link
Member Author

I wonder which tool you used to draw these diagrams. These diagrams look very professional, much better than mine 😢

LOL, really? The previous one is quoted from the previous Mosn source code analysis, which should be drawn with PPT. The following picture is drawn casually with the online software Processon. The function of this software is similar to that of visio, but it can be drawn anywhere and opened. This is very convenient and you can try it.

@seeflood
Copy link
Member

ok. I used processon before, but the diagrams I drawed are too ugly...... 😢

@seeflood seeflood requested a review from zhenjunMa May 23, 2022 07:32
@seeflood seeflood assigned zhenjunMa and unassigned wenxuwan May 23, 2022
@seeflood seeflood requested a review from zu1k May 23, 2022 07:33
docs/zh/blog/code/webassembly/index.md Outdated Show resolved Hide resolved
docs/zh/blog/code/webassembly/index.md Outdated Show resolved Hide resolved
docs/zh/blog/code/webassembly/index.md Outdated Show resolved Hide resolved
docs/zh/blog/code/webassembly/index.md Outdated Show resolved Hide resolved
docs/zh/blog/code/webassembly/index.md Outdated Show resolved Hide resolved
docs/zh/blog/code/webassembly/index.md Outdated Show resolved Hide resolved
@rayowang rayowang requested a review from zhenjunMa May 24, 2022 14:44
zhenjunMa
zhenjunMa previously approved these changes May 26, 2022
Copy link
Contributor

@zhenjunMa zhenjunMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rayowang Hi , I uploaded the images to CDN and submitted a PR to your branch
Please review rayowang#1

@seeflood
Copy link
Member

It's weird that this PR didn't update automatically after merging rayowang#1 😢
@rayowang Could u please update this PR

@rayowang
Copy link
Member Author

It's weird that this PR didn't update automatically after merging rayowang#1 😢 @rayowang Could u please update this PR

I was wondering about this problem just now, and later found out that I have two similar branch names, so the branch of this pr is wasm_code_analysis, not webassembly_code_analysis. So now, do I cherry-pick the changes or do you pr to the wasm_code_analysis branch?

@seeflood
Copy link
Member

@rayowang OK you can cherry pick those changes

@rayowang
Copy link
Member Author

@rayowang OK you can cherry pick those changes

ok, done.

Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks!

@seeflood seeflood merged commit f39dec2 into mosn:main May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants