-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dynamic load wasm file(#191) #577
Conversation
Cool👏👍 |
Coool! |
Codecov Report
@@ Coverage Diff @@
## main #577 +/- ##
==========================================
- Coverage 60.89% 60.62% -0.28%
==========================================
Files 122 125 +3
Lines 6432 6539 +107
==========================================
+ Hits 3917 3964 +47
- Misses 2133 2195 +62
+ Partials 382 380 -2
Continue to review full report at Codecov.
|
@zhenjunMa 做了以下修改:
有空再 review 下哈 ^ _ ^ |
@nanjingboy I'm so sorry for the delay, I have finished the review, please add some unit tests to pass the codecov check👀 |
OK,I'll deal with it as soon as possible |
@zhenjunMa the code is updated,please review it again |
LGTM |
…otto into feat/dynamic_wasm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
@nanjingboy Thanks for this great feature! |
😄 |
What this PR does:
Special notes for your reviewer:
there are three apis to install, update instance number, and unintall WASM file.