Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add secretstores.Metadata #582

Merged
merged 4 commits into from
May 19, 2022
Merged

Conversation

seeflood
Copy link
Member

Signed-off-by: seeflood [email protected]

What this PR does:
add secretstores.Metadata

Which issue(s) this PR fixes:

Fixes #580

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: seeflood <[email protected]>
@mosn-community-bot mosn-community-bot bot added bug Something isn't working cla:yes size/S labels May 19, 2022
@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #582 (23f178a) into main (b6466c2) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #582      +/-   ##
==========================================
+ Coverage   60.62%   60.70%   +0.07%     
==========================================
  Files         120      120              
  Lines        6382     6382              
==========================================
+ Hits         3869     3874       +5     
+ Misses       2143     2139       -4     
+ Partials      370      369       -1     
Impacted Files Coverage Δ
pkg/runtime/config.go 60.00% <ø> (ø)
components/lock/zookeeper/zookeeper_lock.go 64.28% <0.00%> (+8.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c65d7a4...23f178a. Read the comment docs.

zhenjunMa
zhenjunMa previously approved these changes May 19, 2022
@seeflood seeflood merged commit 5db44ed into mosn:main May 19, 2022
@seeflood seeflood deleted the secretstores_metadata branch May 19, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

secret API config shouldn't use bindings.Metadata
3 participants