Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: demo should panic when errors occur #650

Merged
merged 6 commits into from
Jun 14, 2022
Merged

Conversation

seeflood
Copy link
Member

@seeflood seeflood commented Jun 14, 2022

What this PR does:

  • demo should panic when errors occur
  • fix minio error messages
  • delete redundent demos

Which issue(s) this PR fixes:

Fixes #586
Fixes #649

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
@mosn-community-bot mosn-community-bot bot added cla:yes question Further information is requested size/M labels Jun 14, 2022
Signed-off-by: seeflood <[email protected]>
@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #650 (0101ca1) into main (1576bc7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #650   +/-   ##
=======================================
  Coverage   60.92%   60.92%           
=======================================
  Files         120      120           
  Lines        6377     6377           
=======================================
  Hits         3885     3885           
  Misses       2120     2120           
  Partials      372      372           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1576bc7...0101ca1. Read the comment docs.

Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
@seeflood seeflood merged commit c232ee5 into mosn:main Jun 14, 2022
@seeflood seeflood deleted the demo_panic branch June 14, 2022 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes question Further information is requested size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get error from File Demo 修复file api demo中的报错 Demo clients have no assertion
3 participants