Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deploy Layotto with istio 1.10 #697

Merged
merged 6 commits into from
Jul 6, 2022
Merged

Conversation

seeflood
Copy link
Member

@seeflood seeflood commented Jul 4, 2022

Signed-off-by: seeflood [email protected]

What this PR does:
Deploy Layotto with istio 1.10

Which issue(s) this PR fixes:

Fixes #691

Special notes for your reviewer:
This PR won't modify code under cmd/layotto_multiple_api
I will submit a new PR to modify cmd/layotto_multiple_api and the build scripts after all tests(including the bookinfo test) passed

Does this PR introduce a user-facing change?:


Signed-off-by: seeflood <[email protected]>
@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #697 (37a6f45) into main (e3d78d6) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #697      +/-   ##
==========================================
+ Coverage   60.87%   60.95%   +0.07%     
==========================================
  Files         120      120              
  Lines        6388     6388              
==========================================
+ Hits         3889     3894       +5     
+ Misses       2125     2121       -4     
+ Partials      374      373       -1     
Impacted Files Coverage Δ
components/lock/zookeeper/zookeeper_lock.go 64.28% <0.00%> (+8.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a31451...37a6f45. Read the comment docs.

zhenjunMa
zhenjunMa previously approved these changes Jul 4, 2022
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
@seeflood
Copy link
Member Author

seeflood commented Jul 4, 2022

Now we can play with layotto+istio on https://killercoda.com/mosn-tutorial/course/layotto/samples-bookinfo
It uses a special image layotto/proxyv2:test

@Xunzhuo
Copy link
Member

Xunzhuo commented Jul 4, 2022

great, how about naming it with tag layotto/proxyv2:dev?

@seeflood
Copy link
Member Author

seeflood commented Jul 4, 2022

great, how about naming it with tag layotto/proxyv2:dev?

It's a temporary image to demonstrate this PR and makes it easier to review.
After this PR is merged, we can modify the lab and use layotto/proxyv2:latest instead.

@seeflood seeflood merged commit dea867e into mosn:main Jul 6, 2022
@seeflood seeflood deleted the istio_integrate branch July 6, 2022 03:15
@seeflood seeflood mentioned this pull request Jul 9, 2022
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running Layotto with Istio-1.10 failed
3 participants