Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ut unstable of zk lock #701

Merged
merged 4 commits into from
Jul 7, 2022

Conversation

ZLBer
Copy link
Member

@ZLBer ZLBer commented Jul 7, 2022

What this PR does:
fix ut unstable of zookeeper lock, wait connection to close.
Which issue(s) this PR fixes:

Fixes #682

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@mosn-community-bot mosn-community-bot bot added bug Something isn't working cla:yes size/S labels Jul 7, 2022
@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #701 (edd6930) into main (dea867e) will decrease coverage by 0.04%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main     #701      +/-   ##
==========================================
- Coverage   60.95%   60.91%   -0.05%     
==========================================
  Files         120      120              
  Lines        6388     6389       +1     
==========================================
- Hits         3894     3892       -2     
- Misses       2121     2124       +3     
  Partials      373      373              
Impacted Files Coverage Δ
components/lock/zookeeper/zookeeper_lock.go 59.64% <25.00%> (-4.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b30dda7...edd6930. Read the comment docs.

Signed-off-by: seeflood <[email protected]>
@mosn-community-bot mosn-community-bot bot added size/M and removed size/S labels Jul 7, 2022
Signed-off-by: seeflood <[email protected]>
Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seeflood seeflood merged commit 8aa188f into mosn:main Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix unstable ut; 修复不稳定的单测
3 participants