Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve dapr pubsub api #725

Merged
merged 2 commits into from
Jul 19, 2022
Merged

Conversation

seeflood
Copy link
Member

Signed-off-by: seeflood [email protected]

What this PR does:
improve dapr pubsub api
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #725 (9c5abef) into main (0e908fc) will increase coverage by 0.01%.
The diff coverage is 88.46%.

@@            Coverage Diff             @@
##             main     #725      +/-   ##
==========================================
+ Coverage   60.05%   60.06%   +0.01%     
==========================================
  Files         128      128              
  Lines        6766     6769       +3     
==========================================
+ Hits         4063     4066       +3     
  Misses       2311     2311              
  Partials      392      392              
Impacted Files Coverage Δ
pkg/grpc/dapr/dapr_api.go 57.50% <ø> (-1.04%) ⬇️
pkg/grpc/dapr/dapr_api_pubsub.go 42.58% <88.46%> (+1.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e908fc...9c5abef. Read the comment docs.

@seeflood seeflood merged commit 855e9c2 into mosn:main Jul 19, 2022
@seeflood seeflood deleted the improve_dapr_pub branch July 19, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants