-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add proto
file comments linter
#733
Conversation
…layotto into ci_check_proto_comments
Codecov Report
@@ Coverage Diff @@
## main #733 +/- ##
=======================================
Coverage 60.12% 60.12%
=======================================
Files 128 128
Lines 6774 6774
=======================================
Hits 4073 4073
Misses 2310 2310
Partials 391 391 Continue to review full report at Codecov.
|
proto
file commentsproto
file comments linter
@seeflood the ci file and makefile is work it. The final step is adding comments to pass |
@MichaelDeSteven Resolve the lint errors, other than that, LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you all !
What this PR does:
Which issue(s) this PR fixes:
see #623
Special notes for your reviewer:
Does this PR introduce a user-facing change?: