Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GetNextId in ZK component throw zk: node does not exist #752

Merged
merged 5 commits into from
Aug 5, 2022

Conversation

bxiiiiii
Copy link
Contributor

What this PR does:
fix GetNextId in ZK component throw zk: node does not exist
Which issue(s) this PR fixes:

Fixes #747

Special notes for your reviewer:
Determine whether the node exists before set, and create it if it does not exist

@mosn-community-bot mosn-community-bot bot added bug Something isn't working cla:yes size/XS labels Jul 30, 2022
@codecov
Copy link

codecov bot commented Jul 30, 2022

Codecov Report

Merging #752 (1a7e1ff) into main (11db6f2) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #752      +/-   ##
==========================================
- Coverage   60.60%   60.56%   -0.04%     
==========================================
  Files         133      133              
  Lines        8318     8323       +5     
==========================================
  Hits         5041     5041              
- Misses       2700     2705       +5     
  Partials      577      577              
Impacted Files Coverage Δ
...ponents/sequencer/zookeeper/zookeeper_sequencer.go 35.29% <0.00%> (-3.84%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks!

@seeflood seeflood merged commit 3fc2919 into mosn:main Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GetNextId in ZK component throw zk: node does not exist
3 participants