Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use copier to convert structs #803

Merged
merged 2 commits into from
Sep 28, 2022
Merged

feat: use copier to convert structs #803

merged 2 commits into from
Sep 28, 2022

Conversation

seeflood
Copy link
Member

@seeflood seeflood commented Sep 28, 2022

Signed-off-by: seeflood [email protected]

What this PR does:
Use copier to convert structs
I used to use json marshal/unmarshal to convert requests, which is bad :(

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Base: 60.56% // Head: 60.56% // No change to project coverage 👍

Coverage data is based on head (06675ea) compared to base (b07ff39).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #803   +/-   ##
=======================================
  Coverage   60.56%   60.56%           
=======================================
  Files         133      133           
  Lines        8340     8340           
=======================================
  Hits         5051     5051           
  Misses       2712     2712           
  Partials      577      577           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@seeflood seeflood merged commit 7be14b8 into mosn:main Sep 28, 2022
@seeflood seeflood deleted the copier branch September 28, 2022 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants