feat: return rpc detail error message #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 60.50% // Head: 60.55% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #811 +/- ##
==========================================
+ Coverage 60.50% 60.55% +0.04%
==========================================
Files 135 135
Lines 8807 8815 +8
==========================================
+ Hits 5329 5338 +9
+ Misses 2825 2823 -2
- Partials 653 654 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
wenxuwan
changed the title
wenxuwan
changed the title
zhenjunMa
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
When status code is not ResponseStatusSuccess in bolt response, now will return directly, the logic of AfterInvoke will not be executed. If the server returns some abnormal information while reporting an error, the user cannot obtain the specific information of the abnormal information through AfterInvoke
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
When the bolt's status code is not ResponseStatusSuccess, it does not return error directly, but wraps the error information in the RPCResponse structure, and continues to execute the logic in the subsequent AfterInvoke. If the returned error message is successfully parsed in AfterInvoke (here may include information such as the server's specific exception stack), user can print the details of error message
Does this PR introduce a user-facing change?: