Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize TestSuite comparison macro compile times. #140

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Optimize TestSuite comparison macro compile times. #140

wants to merge 3 commits into from

Commits on Jun 1, 2022

  1. TestSuite: create a non-templated base for Comparator. 

    Majority of the work done in this class is template-independent, so this
avoid a lot of needless template instantiations.
    @mosra
    mosra committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    ca98065 View commit details
    Browse the repository at this point in the history

  2. TestSuite: don't go through the container twice in Compare::Container. 

    Since this is a failure case, it doesn't really matter if it takes 10x
more time at runtime. But it definitely adds more work for the compiler,
and that's where most of human time is usually spent -- iterating on the
test code. So don't.
    @mosra
    mosra committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    ac3ad3e View commit details
    Browse the repository at this point in the history

  3. TestSuite: make a non-templated base for Compare::Container. 

    Same as was done for the generic Comparator, but here it's quite a lot
heavier so the impact should be bigger.
    @mosra
    mosra committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    468afdb View commit details
    Browse the repository at this point in the history