We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Line 35 in https://github.com/hellofresh/janus/blob/master/pkg/plugin/basic/middleware.go leaks timing information that can be used to "guess" the password value.
It's a good idea to use the ConstantTimeCompare function (crypto/subtle package).
The text was updated successfully, but these errors were encountered:
Hi @kcq,
Thank you for this report. I'll work on this as soon as possible, or if you'd like you can send a PR.
Sorry, something went wrong.
d1fe91b
Merge pull request #207 from hellofresh/hotfix/constant-time-compare
963ebba
Add constant time compare to basic auth password (fixes #194)
No branches or pull requests
Line 35 in https://github.com/hellofresh/janus/blob/master/pkg/plugin/basic/middleware.go leaks timing information that can be used to "guess" the password value.
It's a good idea to use the ConstantTimeCompare function (crypto/subtle package).
The text was updated successfully, but these errors were encountered: