Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: gnoclient updates from gnomobile for PR #1047 #18

Merged

Conversation

jefft0
Copy link

@jefft0 jefft0 commented Nov 23, 2023

To work on GnoMobile, we made a copy of gnoclient from the PR and made some changes. This is a "PR against the PR" with the changes. It has three commits:

  1. In the Client struct, add methods Render and QEval. Also fix a small copy/paste typo in the error string for QueryAppVersion.
  2. The Signer method Validate had a comment "TODO: Also verify if the password unlocks the account." This implements to verify if the password unlocks the account by signing a blank transaction. Please see issue Validate password by signing a blank transaction. Good idea? gnolang/gno#1324 for more details.
  3. As mentioned in the PR, the type of the QueryAccount parameter addr should be crypto.Address because this is how it is stored in the keys.Info struct . This also checks and returns UnknownAddressError.

@moul moul merged commit 29af0b9 into moul:dev/moul/gnoclient Nov 23, 2023
28 of 29 checks passed
@trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged ✨ Merged Pull Request has been merged successfully and removed 🔍 Ready for Review Pull Request is not reviewed yet ✅ Approved Pull Request has been approved and can be merged ✨ Merged Pull Request has been merged successfully labels Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants