Only draw if read #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check height and width to make sure map is ready to draw.
jonl-percsolutions-com
force-pushed
the
gh-pages
branch
from
86eaf89
to
48d5cef
Compare
|
Can you use the early return pattern instead of wrapping everything with |
|
converted to early return |
| //return if not ready | ||
| if (!this._isReady()) { | ||
| return this; | ||
| } |
There was a problem hiding this comment.
I think we can also inline _isReady here since it's small and not used anywhere else. And remove the curly braces, making it a one-line if/return.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check height and width to make sure map is ready to draw.