Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Cartesian Interpolator and point documentation to use OMPL constrained planner #373

Open
2 tasks
nbbrooks opened this issue Feb 24, 2021 · 2 comments
Open
2 tasks
Assignees
Labels
enhancement New feature or request

Comments

@nbbrooks
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Now that the OMPL constrained planner is merged in, we should remove the Cartesian Interpolator code and any tutorial references. The default method for Cartesian planning should be the OMPL planner. The cartesian interpolator has poor performance and this will improve MoveIt's maintainability by reducing the size of the codebase and feature set.

Describe the solution you'd like

  • Delete Cartesian Interpolator code
  • Update cartesian planning tutorials to reference OMPL planner
@nbbrooks nbbrooks added the enhancement New feature or request label Feb 24, 2021
@felixvd
Copy link
Contributor

felixvd commented Feb 25, 2021

I'm not sure I agree. The interpolator is simple and fast, which is an advantage (I remember this coming up in another issue on the moveit repo). And even if we decided to cut it, wouldn't the pilz_industrial_motion_planner's LIN motion be a more appropriate replacement?

@davetcoleman
Copy link
Member

We would need to get the alternative Cartesian planner (OMPL, Pilz, or whatever) to be similarly easy to setup and use. But I can tell you that one of the #1 issues we fix for our clients at PickNik are the limitations of the Cartesian Interpolator. It really feels wrong to me how poorly it addresses joint limits, singularities, etc yet is promoted in the tutorials.

MikeWrock pushed a commit to MikeWrock/moveit2 that referenced this issue Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants