Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSA] Fix arg parsing in main #1110

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Conversation

DLu
Copy link
Contributor

@DLu DLu commented Mar 10, 2022

Description

Fix the parsing of command line arguments, so that launching MSA from a launch file does not result in an "unknown argument --ros-args" error.

It feels like there should be an easier way to do this, but this is the best I found.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@mergify
Copy link

mergify bot commented Mar 10, 2022

Please target the main branch for development, we will backport the changes to feature/msa for you if approved and if they don't break API.

@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #1110 (929f5f8) into feature/msa (71d2ac5) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           feature/msa    #1110      +/-   ##
===============================================
- Coverage        61.03%   61.02%   -0.01%     
===============================================
  Files              275      275              
  Lines            23761    23761              
===============================================
- Hits             14501    14498       -3     
- Misses            9260     9263       +3     
Impacted Files Coverage Δ
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 74.82% <0.00%> (-1.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71d2ac5...929f5f8. Read the comment docs.

@vatanaksoytezer vatanaksoytezer merged commit 262c9af into moveit:feature/msa Mar 15, 2022
DLu added a commit to DLu/moveit2 that referenced this pull request May 19, 2022
vatanaksoytezer pushed a commit that referenced this pull request May 25, 2022
vatanaksoytezer pushed a commit that referenced this pull request May 31, 2022
vatanaksoytezer pushed a commit that referenced this pull request May 31, 2022
DLu added a commit to DLu/moveit2 that referenced this pull request Jun 13, 2022
DLu added a commit to DLu/moveit2 that referenced this pull request Jun 13, 2022
vatanaksoytezer pushed a commit that referenced this pull request Jun 14, 2022
peterdavidfagan pushed a commit to peterdavidfagan/moveit2 that referenced this pull request Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants