Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexibility in moveit_configs_utils reading of .setup_assistant #1264

Merged
merged 1 commit into from
May 19, 2022

Conversation

DLu
Copy link
Contributor

@DLu DLu commented May 19, 2022

Description

Fix bug described in #1254 (review)

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

Copy link
Contributor

@vatanaksoytezer vatanaksoytezer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested, and fixes the said error. I think still we won't be able to launch anything before controllers.yaml files are generated though (at least moveit_configs_utils seems upset about it)

@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #1264 (2fbee6b) into main (6c690db) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1264   +/-   ##
=======================================
  Coverage   61.44%   61.44%           
=======================================
  Files         274      274           
  Lines       24936    24936           
=======================================
  Hits        15319    15319           
  Misses       9617     9617           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c690db...2fbee6b. Read the comment docs.

@DLu
Copy link
Contributor Author

DLu commented May 19, 2022

That sounds like it needs a separate issue.

@JafarAbdi JafarAbdi merged commit 11d83b7 into moveit:main May 19, 2022
@DLu DLu deleted the capital_letters_configs_builder branch May 23, 2022 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants