Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI for Rolling / Ubuntu Noble #2793

Merged
merged 7 commits into from
May 23, 2024
Merged

Conversation

rhaschke
Copy link
Contributor

CI builds for rolling are broken since a month or so. This PR fixes the docker images as well as some deprecated code.
I am surprised that nobody from the MoveIt2 maintainer team attempted to fix those issues yet.
Essentially, it was just about adding packages to moveit2.repos, which are not yet binary-released.

The ci-testing docker file, building upon osrf/ros2:testing is broken upstream. I skipped building this image for now as I don't know the intention of using osrf/ros2:testing.

rhaschke and others added 4 commits April 15, 2024 19:36
osrf/ros2:testing doesn't contain /opt/ros!
check for header to stay compatible with ubuntu 20.04.

Support boost >= 1.83

Slightly ugly due to the double alias, but boost::timer was a class
before 1.72, so using `boost::timer::progress_display` in the code
breaks with older versions.

cherry-pick of #3547 from MoveIt1
@rhaschke
Copy link
Contributor Author

Obviously, there is more to do in order to fix all CI checks. This PR just fixes the docker image builds.
I will leave the remaining checks to the MoveIt2 maintainer team.

@rhaschke
Copy link
Contributor Author

rhaschke commented May 15, 2024

Ping @henningkayser: This PR fixes the docker builds, thus making the docker images usable again.
Even though there are other issues to fix, you should consider merging this.

@rhaschke rhaschke removed the request for review from tylerjw May 15, 2024 11:10
Copy link
Member

@henningkayser henningkayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@henningkayser henningkayser merged commit bee0a29 into moveit:main May 23, 2024
11 of 15 checks passed
@henningkayser henningkayser mentioned this pull request May 23, 2024
10 tasks
@rhaschke rhaschke deleted the fix-ci branch May 23, 2024 13:16
This was referenced May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants