-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI for Rolling / Ubuntu Noble #2793
Conversation
osrf/ros2:testing doesn't contain /opt/ros!
check for header to stay compatible with ubuntu 20.04. Support boost >= 1.83 Slightly ugly due to the double alias, but boost::timer was a class before 1.72, so using `boost::timer::progress_display` in the code breaks with older versions. cherry-pick of #3547 from MoveIt1
Obviously, there is more to do in order to fix all CI checks. This PR just fixes the docker image builds. |
Ping @henningkayser: This PR fixes the docker builds, thus making the docker images usable again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
CI builds for rolling are broken since a month or so. This PR fixes the docker images as well as some deprecated code.
I am surprised that nobody from the MoveIt2 maintainer team attempted to fix those issues yet.
Essentially, it was just about adding packages to moveit2.repos, which are not yet binary-released.
The
ci-testing
docker file, building uponosrf/ros2:testing
is broken upstream. I skipped building this image for now as I don't know the intention of usingosrf/ros2:testing
.