Fix segmentation fault in mesh_filter/gl_renderer #2834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The misusage of std::map is fixed.
sjahr
reviewed
May 27, 2024
There was a problem hiding this comment.
@CihatAltiparmak Can you check if my suggestion fixes the error?
Co-authored-by: Sebastian Jahr <[email protected]>
sjahr
approved these changes
May 28, 2024
There was a problem hiding this comment.
@CihatAltiparmak Can you run pre-commit to fix the formatting? The we can merge this 👍
|
It was done. |
henningkayser
approved these changes
May 31, 2024
henningkayser
added
backport-humble
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The misusage of std::map is fixed.
Checklist