Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Doc Link #235

Merged
merged 6 commits into from
Dec 21, 2021
Merged

New Doc Link #235

merged 6 commits into from
Dec 21, 2021

Conversation

DLu
Copy link
Contributor

@DLu DLu commented Dec 8, 2021

Description

Necessary yak-shaving before #234. Adds new extlinks format for linking to ROS 2 docs

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

doc/getting_started/getting_started.rst Outdated Show resolved Hide resolved
@tylerjw
Copy link
Member

tylerjw commented Dec 8, 2021

I does look like you need to run pre-commit (which will run black) to get it to pass the format CI job.

@DLu
Copy link
Contributor Author

DLu commented Dec 8, 2021

Build is broken on some hybrid planner shiz @henningkayser

In file included from /home/runner/work/moveit2_tutorials/moveit2_tutorials/.work/upstream_ws/src/moveit2/moveit_ros/hybrid_planning/hybrid_planning_manager/hybrid_planning_manager_component/src/hybrid_planning_manager.cpp:35:
  /home/runner/work/moveit2_tutorials/moveit2_tutorials/.work/upstream_ws/src/moveit2/moveit_ros/hybrid_planning/hybrid_planning_manager/hybrid_planning_manager_component/include/moveit/hybrid_planning_manager/hybrid_planning_manager.h:44:10: fatal error: moveit_msgs/action/local_planner.hpp: No such file or directory
     44 | #include <moveit_msgs/action/local_planner.hpp>
        |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  compilation terminated.

@mergify
Copy link

mergify bot commented Dec 15, 2021

This pull request is in conflict. Could you fix it @DLu?

@DLu
Copy link
Contributor Author

DLu commented Dec 21, 2021

Conflicts resolved, CI passes.

@tylerjw tylerjw merged commit 0c69b1c into moveit:main Dec 21, 2021
@DLu DLu deleted the new_doc_link branch December 21, 2021 16:11
DLu added a commit to DLu/moveit2_tutorials that referenced this pull request Dec 21, 2021
@DLu DLu mentioned this pull request Dec 21, 2021
2 tasks
tylerjw pushed a commit that referenced this pull request Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants