Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ros naming #473

Merged
merged 6 commits into from
Jul 15, 2022
Merged

Ros naming #473

merged 6 commits into from
Jul 15, 2022

Conversation

MikeWrock
Copy link
Contributor

Description

Please explain the changes you made, including a reference to the related issue if applicable

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

MikeWrock and others added 4 commits July 15, 2022 02:02
* renamed cartesian limits file (moveit#472)

* Tutorial dockerfiles (moveit#463)

Build and push docker images for tutorials

* fixed clang complaints

* removed dockerhub pushes

* successfully ran htmlproofer

* removed chomp tutorial commits

* removed accidental commits

* Update CMakeLists.txt

* renamed mtc tutorial cpp file

* updated cmakelists

* updated cmakelists

* removed vscode

* refactored docker

* skipping base image

* added conditions on building base image

* added conditions on building base image

* added conditions on building base image

* ran pre commit

* Update .docker/Dockerfile

Co-authored-by: Robert Haschke <[email protected]>

* Update .docker/Dockerfile

Co-authored-by: Robert Haschke <[email protected]>

* resolved comments

* updated location to check for changes

* test change to dockerfile

* test change to dockerfile

* test change to dockerfile

* updated scripts to run only when dockerfile changes

* fixed syntax

* chaged to ros base image

* chaged to ros base image

* update

* removed ccache and change repo names

* removed ccache and change repo names

Co-authored-by: Henry Moore <[email protected]>
Co-authored-by: Robert Haschke <[email protected]>
* Tutorial dockerfiles (moveit#463)

Build and push docker images for tutorials

* fixed clang complaints

* removed dockerhub pushes

* successfully ran htmlproofer

* removed chomp tutorial commits

* removed accidental commits

* Update CMakeLists.txt

* renamed mtc tutorial cpp file

* updated cmakelists

* updated cmakelists

* removed vscode

* refactored docker

* skipping base image

* added conditions on building base image

* added conditions on building base image

* added conditions on building base image

* ran pre commit

* Update .docker/Dockerfile

Co-authored-by: Robert Haschke <[email protected]>

* Update .docker/Dockerfile

Co-authored-by: Robert Haschke <[email protected]>

* resolved comments

* updated location to check for changes

* test change to dockerfile

* test change to dockerfile

* test change to dockerfile

* updated scripts to run only when dockerfile changes

* fixed syntax

* got it building

* building dockerfiles of tutorials

* added pick container

* pushing to new pc

* changed to multi-stage

* updated dockerfile

* rebased

* continued rebasing

* continued rebasing

* continued rebasing

* continued rebasing

* continued rebasing

* merged online edit

* continued rebasing

* pre commit

* modified dockerfile

* added ccache to path

* merging

* merging

* successfully ran htmlproofer

* removed chomp tutorial commits

* removed accidental commits

* Update CMakeLists.txt

* renamed mtc tutorial cpp file

* updated cmakelists

* updated cmakelists

* removed vscode

* merging

* merging

* ran pre commit

* Update .docker/Dockerfile

Co-authored-by: Robert Haschke <[email protected]>

* Update .docker/Dockerfile

Co-authored-by: Robert Haschke <[email protected]>

* resolved comments

* test change to dockerfile

* test change to dockerfile

* test change to dockerfile

* merging

* changed dockerfile

* changed dockerfile

* changed dockerfile

* changed dockerfile

* changed dockerfile

Co-authored-by: Robert Haschke <[email protected]>
@mergify
Copy link

mergify bot commented Jul 15, 2022

This pull request is in conflict. Could you fix it @MikeWrock?

@MikeWrock MikeWrock merged commit ff3fc10 into moveit:docker_debug Jul 15, 2022
@MikeWrock MikeWrock deleted the ros_naming branch July 15, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant