Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove/replace deprecated use of JumpThreshold #984

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Remove/replace deprecated use of JumpThreshold #984

merged 2 commits into from
Nov 4, 2024

Conversation

sea-bass
Copy link
Contributor

@sea-bass sea-bass commented Nov 3, 2024 •
edited
Loading

Description

Since moveit/moveit2#2916, the JumpThreshold in cartesian interpolator was removed and/or replaced with a CartesianPrecision struct.

This PR brings things up to date, thereby removing deprecation warnings when compiling.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

@sea-bass sea-bass mentioned this pull request Nov 3, 2024
Closed
@marioprats
Copy link
Contributor

Thanks Sebastian!

@marioprats marioprats merged commit 59b03cc into main Nov 4, 2024
9 checks passed
@marioprats marioprats deleted the remove-jump-thresh branch November 4, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioprats marioprats marioprats approved these changes

@rhaschke rhaschke Awaiting requested review from rhaschke

@sjahr sjahr Awaiting requested review from sjahr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sea-bass @marioprats